flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6725) make requiresOver as a contracted method in udagg
Date Mon, 17 Jul 2017 07:32:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089427#comment-16089427

ASF GitHub Bot commented on FLINK-6725:

Github user shaoxuan-wang commented on the issue:

     @fhueske @sunjincheng121 @wuchong, thanks for the valuable inputs. We talked offline
and get an agreement that we'd better to put `getAccumulatorType()`, `getResultType()` etc.
in `AggregateFunction`. Sorry that I forgot to update this Jira. Let us move this change to
[FLINK-7194](https://issues.apache.org/jira/browse/FLINK-7194). I will close this PR and [FLINK-6725](https://issues.apache.org/jira/browse/FLINK-6725).

> make requiresOver as a contracted method in udagg
> -------------------------------------------------
>                 Key: FLINK-6725
>                 URL: https://issues.apache.org/jira/browse/FLINK-6725
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Shaoxuan Wang
> I realized requiresOver is defined in the udagg interface when I wrote up the udagg doc.
I would like to put requiresOver as a contract method. This makes the entire udagg interface
consistently and clean.

This message was sent by Atlassian JIRA

View raw message