flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6842) Uncomment or remove code in HadoopFileSystem
Date Thu, 06 Jul 2017 15:04:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076661#comment-16076661
] 

ASF GitHub Bot commented on FLINK-6842:
---------------------------------------

Github user zhangminglei commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4219#discussion_r125926605
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/fs/hdfs/HadoopFileSystem.java
---
    @@ -459,17 +459,14 @@ public boolean isDistributedFS() {
     	@Override
     	public Class<?> getHadoopWrapperClassNameForFileSystem(String scheme) {
     		Configuration hadoopConf = getHadoopConfiguration();
    -		Class<? extends org.apache.hadoop.fs.FileSystem> clazz;
    -		// We can activate this block once we drop Hadoop1 support (only hd2 has the getFileSystemClass-method)
    -//		try {
    -//			clazz = org.apache.hadoop.fs.FileSystem.getFileSystemClass(scheme, hadoopConf);
    -//		} catch (IOException e) {
    -//			LOG.info("Flink could not load the Hadoop File system implementation for scheme
"+scheme);
    -//			return null;
    -//		}
    -		clazz = hadoopConf.getClass("fs." + scheme + ".impl", null, org.apache.hadoop.fs.FileSystem.class);
    -
    -		if (clazz != null && LOG.isDebugEnabled()) {
    +		Class<? extends org.apache.hadoop.fs.FileSystem> clazz = null;
    +		try {
    +			clazz = org.apache.hadoop.fs.FileSystem.getFileSystemClass(scheme, hadoopConf);
    +		} catch (IOException e) {
    +			LOG.info("Flink could not load the Hadoop File system implementation for scheme "
+ scheme);
    +		}
    +
    +		if(LOG.isDebugEnabled()) {
    --- End diff --
    
    Had updated code. Well fine ~ :)


> Uncomment or remove code in HadoopFileSystem
> --------------------------------------------
>
>                 Key: FLINK-6842
>                 URL: https://issues.apache.org/jira/browse/FLINK-6842
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: mingleizhang
>            Priority: Minor
>
> I've found the following code in {{HadoopFileSystem#getHadoopWrapperClassNameForFileSystem}}
> {code}
> Configuration hadoopConf = getHadoopConfiguration();
> Class<? extends org.apache.hadoop.fs.FileSystem> clazz;
> // We can activate this block once we drop Hadoop1 support (only hd2 has the getFileSystemClass-method)
> //try {
> //	clazz = org.apache.hadoop.fs.FileSystem.getFileSystemClass(scheme, hadoopConf);
> //} catch (IOException e) {
> //	LOG.info("Flink could not load the Hadoop File system implementation for scheme "+scheme);
> //	return null;
> //}
> clazz = hadoopConf.getClass("fs." + scheme + ".impl", null, org.apache.hadoop.fs.FileSystem.class);
> if (clazz != null && LOG.isDebugEnabled()) {
> 	LOG.debug("Flink supports {} with the Hadoop file system wrapper, impl {}", scheme,
clazz);
> }
> return clazz;
> {code}
> Since we don't support hadoop1 anymore the commented code should either be activated
or removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message