flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6964) Fix recovery for incremental checkpoints in StandaloneCompletedCheckpointStore
Date Fri, 14 Jul 2017 13:14:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087295#comment-16087295
] 

ASF GitHub Bot commented on FLINK-6964:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4192#discussion_r127453095
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/IncrementalKeyedStateHandleTest.java
---
    @@ -187,7 +188,7 @@ public void testSharedStateDeRegistration() throws Exception {
     
     	private static IncrementalKeyedStateHandle create(Random rnd) {
     		return new IncrementalKeyedStateHandle(
    -			"test",
    +			UUID.nameUUIDFromBytes("test".getBytes()),
    --- End diff --
    
    Let's set the right example for everyone that "learns by reading" other code.
    Also, we have seen cases where tests were unstable when executed on an Italian Laptop
because of different default locales and charsets ;-)


> Fix recovery for incremental checkpoints in StandaloneCompletedCheckpointStore
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-6964
>                 URL: https://issues.apache.org/jira/browse/FLINK-6964
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Blocker
>             Fix For: 1.3.2
>
>
> {{StandaloneCompletedCheckpointStore}} does not register shared states ion resume. However,
for externalized checkpoints, it register the checkpoint from which it resumed. This checkpoint
gets added to the completed checkpoint store as part of resume.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message