flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7187) Activate checkstyle flink-java/sca
Date Wed, 19 Jul 2017 15:14:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093244#comment-16093244
] 

ASF GitHub Bot commented on FLINK-7187:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4337#discussion_r128276458
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/sca/TaggedValue.java ---
    @@ -46,7 +50,10 @@
     		NULL // null
     	}
     
    -	public static enum Input {
    +	/**
    +	 * Inputs types.
    --- End diff --
    
    This is a bit misleading, I believe these are used a tags to remember which input they
belong to for 2 input operators (like coGroup for example). They may have the same type though
;)


> Activate checkstyle flink-java/sca
> ----------------------------------
>
>                 Key: FLINK-7187
>                 URL: https://issues.apache.org/jira/browse/FLINK-7187
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Dawid Wysakowicz
>            Assignee: Dawid Wysakowicz
>            Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message