flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7303) Build elasticsearch5 by default
Date Mon, 31 Jul 2017 12:12:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107219#comment-16107219
] 

ASF GitHub Bot commented on FLINK-7303:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4426

    [FLINK-7303] [build] Build elasticsearch5 by default

    ## What is the purpose of the change
    
    Remove unnecessary include-elasticsearch5 profile since its activation condition (usage
of jdk8) is always true.
    
    ## Verifying this change
    
    Run any mvn command in `flink` or `flink-connectors` and check that the reactor includes
ES5.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (~~yes~~ /  no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ~~(yes~~
/ no)
      - The serializers: (~~yes~~ / no / ~~don't know~~)
      - The runtime per-record code paths (performance sensitive): (~~yes~~ / no / ~~don't
know~~)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (~~yes~~ / no / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (~~yes~~ / no)
      - If yes, how is the feature documented? (not applicable ~~/ docs / JavaDocs / not documented~~)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7303

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4426.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4426
    
----
commit bf91de71f756aae428adc20e3479c40bd73babc7
Author: zentol <chesnay@apache.org>
Date:   2017-07-31T10:16:05Z

    [FLINK-7303] [build] Build elasticsearch5 by default

----


> Build elasticsearch5 by default
> -------------------------------
>
>                 Key: FLINK-7303
>                 URL: https://issues.apache.org/jira/browse/FLINK-7303
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Batch Connectors and Input/Output Formats, Build System
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>
> The elasticsearch-5 connector is optionally included in flink-connectors, based on whether
jdk8 is used or not. Now that we drop java 7 support we can include it by default.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message