flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7313) Add conversion utilities (Scala and old Flink futures)
Date Mon, 31 Jul 2017 14:06:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107345#comment-16107345
] 

ASF GitHub Bot commented on FLINK-7313:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4429

    [FLINK-7313] [futures] Add Flink future and Scala future to Java 8 CompletableFuture conversion

    ## What is the purpose of the change
    
    Introduce conversion utilities to convert Scala `Futures` and Flink's own `Futures` into
`CompletableFutures`.
    
    ## Brief change log
    
    - Add DirectExecutionContext
    - Add Scala Future to Java 8 CompletableFuture utility to FutureUtils
    - Add Flink future to Java 8's CompletableFuture conversion utility to FutureUtils
    - Add base class for Flink's unchecked future exceptions
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink futureConversions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4429.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4429
    
----
commit afe1d171132bb3724e672a1c4ce74a3f7c185908
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2017-07-31T13:07:18Z

    [FLINK-7313] [futures] Add Flink future and Scala future to Java 8 CompletableFuture conversion
    
    Add DirectExecutionContext
    
    Add Scala Future to Java 8 CompletableFuture utility to FutureUtils
    
    Add Flink future to Java 8's CompletableFuture conversion utility to FutureUtils
    
    Add base class for Flink's unchecked future exceptions

----


> Add conversion utilities (Scala and old Flink futures)
> ------------------------------------------------------
>
>                 Key: FLINK-7313
>                 URL: https://issues.apache.org/jira/browse/FLINK-7313
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>             Fix For: 1.4.0
>
>
> In order to replace Flink's own {{Futures}} with Java 8's {{CompletableFutures}} we need
some conversion utility to transform Scala's {{Futures}} and Flink's old {{Futures}} into
Java 8's {{CompletableFutures}} until we have completed the replacement.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message