flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7318) Remove Flink's futures from StackTraceSampleCoordinator
Date Mon, 31 Jul 2017 16:12:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107511#comment-16107511
] 

ASF GitHub Bot commented on FLINK-7318:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4431#discussion_r130396606
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/BackPressureStatsTracker.java
---
    @@ -177,7 +177,7 @@ public boolean triggerStackTraceSample(ExecutionJobVertex vertex)
{
     						LOG.debug("Triggering stack trace sample for tasks: " + Arrays.toString(vertex.getTaskVertices()));
     					}
     
    -					Future<StackTraceSample> sample = coordinator.triggerStackTraceSample(
    +					CompletableFuture<StackTraceSample> sample = coordinator.triggerStackTraceSample(
    --- End diff --
    
    Why not you not returning a plain `Future` here? Shouldn't we only explicitly return a
`CompletableFuture` if we expect the caller to complete it?


> Remove Flink's futures from StackTraceSampleCoordinator
> -------------------------------------------------------
>
>                 Key: FLINK-7318
>                 URL: https://issues.apache.org/jira/browse/FLINK-7318
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message