flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4444: [FLINK-7331] [futures] Replace Flink's Future with...
Date Tue, 01 Aug 2017 08:37:13 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4444#discussion_r130549382
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
    @@ -401,74 +354,37 @@ public RegistrationResponse apply(RegistrationResponse registrationResponse,
Thr
     	 * @return The response by the ResourceManager.
     	 */
     	@RpcMethod
    -	public Future<RegistrationResponse> registerTaskExecutor(
    --- End diff --
    
    Unintended renaming? This method is annotated with `@RcpMethod`, we need to change `ResourceManagerGateway`
as well. Although this begs the question why we expose an _internal_ method in the first place.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message