flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink issue #4380: Time sort with offset/fetch without retraction
Date Tue, 01 Aug 2017 08:56:41 GMT
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/4380
  
    OK @rtudoran, that sounds good to me.
    
    I haven't had a detailed look at the retraction code you submitted before. If it has the
right semantics for `ORDER BY *time DESC FETCH x`, please open a new PR and I'll be happy
to review it.
    
    Regarding `ORDER BY *time ASC OFFSET / FETCH`, I'd modify this PR according to the comments.
    
    I didn't understand the issue with `LIMIT` yet. Why is `LIMIT 10` not equivalent to `FETCH
FIRST 10 ROWS ONLY`? Both should return 10 rows, right? Aside from this question, I think
if Calcite parses and translates `LIMIT` as `FETCH` the right way to change the behavior would
be to fix it in Calcite.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message