flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #4447: [FLINK-7312][checkstyle] activate checkstyle for flink/co...
Date Tue, 01 Aug 2017 12:56:48 GMT
Github user StephanEwen commented on the issue:

    At the first quick glance: This is removing a lot of `final` keywords from various methods.
    While one could argue that this keyword is not strictly necessary (the class as a whole
is final), I put them there on purpose when writing this originally, to "document" the intention
that these methods should not be ever overridden, regardless of whether the class as a whole
would be subclass-able.
    I would vote to leave this in place, actually. While actually improving / cleaning up
bad code is a nice thing to do as part of reworking parts, I think this is good practice to
not try and just change things that could be changed, just for the sake of changing them,
or because of a personal view of "what would look nicer".
    There is frequently a reason why things are as they are, especially in modules like the
memory segments that were written very carefully and consciously.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message