flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #4447: [FLINK-7312][checkstyle] activate checkstyle for flink/co...
Date Tue, 01 Aug 2017 14:04:34 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4447
  
    If the tooling is hard to be made to cooperate, then I am not religious about the `final`
keyword here.
    
    This is more of a general theme: I am trying to advocate to not change things "just because
it looks better". 
    Once you did your first set of late night debugging sessions and found that the bug was
introduced by a "cleanup" change, you may know why I feel quite strongly about this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message