flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #4447: [FLINK-7312][checkstyle] activate checkstyle for flink/co...
Date Tue, 01 Aug 2017 16:08:24 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4447
  
    Thinking more about this, I think we should modify the checkstyle to not force us to remove
such `final` keywords. While being redundant in the current "snapshot" of the code, they may
not be redundant in the future. I think there is a big upside of writing code in a "future
proof" way.
    
    The modifiers in this class are a good example of that - the JIT friendlyness of the methods
is so important that they should not be affected by future changes the class hierarchy.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message