flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #4447: [FLINK-7312][checkstyle] activate checkstyle for flink/co...
Date Tue, 01 Aug 2017 16:29:35 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4447
  
    Final key-words on non-static methods should always be an exception, no matter whether
checkstyle marks them as a violation.
    
    Talking to @NicoK offline, he mentioned that there have been commits with such changes
merged. What do we do about these now? Are we sure we did not void a statement that the authors
put in place to the code to be future proof`?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message