flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dawidwys <...@git.apache.org>
Subject [GitHub] flink pull request #4296: [FLINK-7147] [cep] Support greedy quantifier in CE...
Date Mon, 07 Aug 2017 11:09:02 GMT
Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4296#discussion_r131628265
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
    @@ -386,6 +387,19 @@ private void checkPatternNameUniqueness(final Pattern pattern) {
     			return copyOfSink;
     		}
     
    +		private State<T> copy(final State<T> state) {
    +			final State<T> copyOfState = new State<>(state.getName(), state.getStateType());
    --- End diff --
    
    The copy should be made with `createState` method which does ensure there is a unique
name assigned, which is neccessary for the serialization.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message