flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StefanRRichter <...@git.apache.org>
Subject [GitHub] flink issue #4445: [FLINK-7310][core] always use the HybridMemorySegment
Date Mon, 07 Aug 2017 12:41:27 GMT
Github user StefanRRichter commented on the issue:

    https://github.com/apache/flink/pull/4445
  
    I think the implementation of the change is good, but the performance impact seems noticeable,
at least in some cases. I think the additional bounds checking in the hybrid case shows. Out
of curiosity I deactivated the index bounds checks and this closed all gaps between `HeapMemorySegment`
and `HybridMemorySegment` in the benchmarks that @NicoK mentioned.
    
    If @StephanEwen has no concerns about the performance regression, I think this could be
merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message