flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4545: [FLINK-6805] [Cassandra-Connector] Shade indirect ...
Date Wed, 16 Aug 2017 09:57:47 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4545#discussion_r133407236
  
    --- Diff: flink-connectors/flink-connector-cassandra/pom.xml ---
    @@ -83,6 +85,10 @@ under the License.
     										<exclude>com.google.inject.**</exclude>
     									</excludes>
     								</relocation>
    +								<relocation>
    +									<pattern>io.netty</pattern>
    +									<shadedPattern>org.apache.flink.shaded.netty4.io.netty</shadedPattern>
    --- End diff --
    
    1) We haven't written them down anywhere; but there are examples on how the pattern should
look like in many modules. (Granted, there are some relocations that don't follow the points
I made; standardizing them is a work-in-progress) I would generally refer to existing relocations
instead of some document that is bound to be out-dated at some point.
    2) Currently we shade&relocate dependencies that already caused conflicts.
    3) Yes, but there is no better solution. While it is possible to re-use some dependencies
from Flink this tends to be a maintaining nightmare, as an upgrade to a dependency can suddenly
cause issues in another part. The netty shading is a perfect example of this: we replaced
the netty dependency and now the connector is broken.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message