flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink issue #4554: [FLINK-7442] Add option for using child-first classloader...
Date Fri, 18 Aug 2017 13:19:05 GMT
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/4554
  
    Yes, I created an alternative PR for that: https://github.com/apache/flink/pull/4564
    
    My only worry is that all the tests in that PR would also pass with the other child-first
class loader implementation from the RocksDB test, meaning that we don't actually have coverage
for something that I discovered by having the class loader in the client. If we're fine with
that I will close this PR and merge the other one once it's reviewed. 👌 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message