flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From EronWright <...@git.apache.org>
Subject [GitHub] flink issue #4415: [FLINK-7269] Refactor passing of dynamic properties
Date Sun, 20 Aug 2017 20:05:58 GMT
Github user EronWright commented on the issue:

    https://github.com/apache/flink/pull/4415
  
    @tillrohrmann @zentol the whole reason for the static field is to allow the various sites
that call GlobalConfiguration.loadConfiguration to obtain the dynamic properties.    Any property
could be overridden.  Since there are many, many such sites, this patch causes a potential
regression.  
    
    Is there a driving rationale for this aside from a general dislike for statics?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message