flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4569: [FLINK-7040] [REST] Add basics for REST communicat...
Date Tue, 22 Aug 2017 16:07:43 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4569#discussion_r134528391
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/ParameterMapper.java
---
    @@ -0,0 +1,83 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.rest.messages;
    +
    +import java.util.Collections;
    +import java.util.Iterator;
    +import java.util.Map;
    +import java.util.Set;
    +
    +/**
    + * This class is used to map query/path {@link Parameter}s to their actual value.
    + */
    +public abstract class ParameterMapper {
    +
    +	/**
    +	 * Maps the given query {@link Parameter}s to their actual value.
    +	 *
    +	 * @param queryParameters parameters to map
    +	 * @return map containing the parameters and their associated value
    +	 */
    +	public Map<Parameter, String> mapQueryParameters(Set<Parameter> queryParameters)
{
    +		return Collections.emptyMap();
    +	}
    +
    +	/**
    +	 * Maps the given path {@link Parameter}s to their actual value.
    +	 *
    +	 * @param pathParameters parameters to map
    +	 * @return map containing the parameters and their associated value
    +	 */
    +	public Map<Parameter, String> mapPathParameters(Set<Parameter> pathParameters)
{
    +		return Collections.emptyMap();
    +	}
    +
    +	/**
    +	 * Resolves the given URL (e.g "jobs/:jobid") using the given path/query parameters.
    +	 *
    +	 * @param genericUrl      URL to resolve
    +	 * @param pathParameters  path parameters
    +	 * @param queryParameters query parameters
    +	 * @return resolved url, e.g "/jobs/1234?state=running"
    +	 */
    +	public static String resolveUrl(String genericUrl, Map<Parameter, String> pathParameters,
Map<Parameter, String> queryParameters) {
    +		StringBuilder sb = new StringBuilder(genericUrl);
    +
    +		pathParameters.forEach((parameter, value) -> {
    +			int start = sb.indexOf(":" + parameter.getKey());
    +			sb.replace(start, start + parameter.getKey().length() + 1, value);
    +		});
    --- End diff --
    
    But we could, for example, count how many placeholders there are in the request URL and
check that all of them have been replaced, couldn't we? Or is it also a valid request URL
if a placeholder has not been replaced with a concrete value?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message