flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tedyu <...@git.apache.org>
Subject [GitHub] flink pull request #4410: [FLINK-7268] [checkpoints] Scope SharedStateRegist...
Date Wed, 23 Aug 2017 02:55:09 GMT
Github user tedyu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4410#discussion_r134647310
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
    @@ -1044,10 +1049,23 @@ public boolean restoreLatestCheckpointedState(
     				throw new IllegalStateException("CheckpointCoordinator is shut down");
     			}
     
    -			// Recover the checkpoints
    -			completedCheckpointStore.recover(sharedStateRegistry);
    +			// We create a new shared state registry object, so that all pending async disposal
requests from previous
    +			// runs will go against the old object (were they can do no harm).
    +			// This must happen under the checkpoint lock.
    +			sharedStateRegistry.close();
    +			sharedStateRegistry = sharedStateRegistryFactory.create(executor);
    +
    +			// Recover the checkpoints, TODO this could be done only when there is a new leader,
not on each recovery
    --- End diff --
    
    If we use highAvailabilityServices.getJobManagerLeaderRetriever(), Job Id is required.
    Can Job Id be obtained from JobVertexID ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message