flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tedyu <...@git.apache.org>
Subject [GitHub] flink pull request #4296: [FLINK-7147] [cep] Support greedy quantifier in CE...
Date Fri, 25 Aug 2017 22:37:24 GMT
Github user tedyu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4296#discussion_r135366122
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java
---
    @@ -421,6 +437,15 @@ private void addStopStateToLooping(final State<T> loopingState)
{
     				untilCondition,
     				true);
     
    +			if (currentPattern.getQuantifier().hasProperty(Quantifier.QuantifierProperty.GREEDY)
&&
    +				times.getFrom() != times.getTo()) {
    +				if (untilCondition != null) {
    +					State<T> sinkStateCopy = copy(sinkState);
    +					originalStateMap.put(sinkState.getName(), sinkStateCopy);
    --- End diff --
    
    When are the old entries cleared in this map ?
    Shall we consider using map which expires entries by TTL ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message