flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wuchong <...@git.apache.org>
Subject [GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...
Date Mon, 28 Aug 2017 01:57:39 GMT
Github user wuchong commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkTableFunctionImpl.scala
    @@ -71,6 +69,9 @@ class FlinkTableFunctionImpl[T](
       override def getElementType(arguments: util.List[AnyRef]): Type = classOf[Array[Object]]
    +  // we do never use the FunctionParameters, so return an empty list
    +  override def getParameters: util.List[FunctionParameter] = Collections.emptyList()
    --- End diff --
    `ReflectiveFunctionBase#getParameters` is used to create `SqlOperandTypeChecker` in the
previous implementation. But with the new implementation, we don't need the `ReflectiveFunctionBase#getParameters`
to create `SqlOperandTypeChecker`. So I think we can just return an empty list.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message