flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chesnay Schepler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6805) Flink Cassandra connector dependency on Netty disagrees with Flink
Date Mon, 14 Aug 2017 10:58:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125534#comment-16125534
] 

Chesnay Schepler commented on FLINK-6805:
-----------------------------------------

FLINK-6982 is about shading _direct_ guava dependencies of Flink; for example {{flink-optimizer}}
has a direct guava dependency, that (will) now use the a shaded version. All modules that
have a direct dependency will use this one.

The cassandra module is different since it only has an indirect guava/netty dependency through
the datastax driver. This module shades a separate version of guava, that isn't connected
in any way to the one used by the rest of Flink. The same should be done with the netty dependency.

This should be very easy to implement, as you only have to modify the maven-shade-plugin configuration
in the pom of the cassandra module, adding an inclusion&relocation for the netty dependencies.

> Flink Cassandra connector dependency on Netty disagrees with Flink
> ------------------------------------------------------------------
>
>                 Key: FLINK-6805
>                 URL: https://issues.apache.org/jira/browse/FLINK-6805
>             Project: Flink
>          Issue Type: Bug
>          Components: Cassandra Connector
>    Affects Versions: 1.3.0, 1.2.1
>            Reporter: Shannon Carey
>             Fix For: 1.4.0
>
>
> The Flink Cassandra connector has a dependency on Netty libraries (via promotion of transitive
dependencies by the Maven shade plugin) at version 4.0.33.Final, which disagrees with the
version included in Flink of 4.0.27.Final which is included & managed by the parent POM
via dependency on netty-all.
> Due to use of netty-all, the dependency management doesn't take effect on the individual
libraries such as netty-handler, netty-codec, etc.
> I suggest that dependency management of Netty should be added for all Netty libraries
individually (netty-handler, etc.) so that all Flink modules use the same version, and similarly
I suggest that exclusions be added to the quickstart example POM for the individual Netty
libraries so that fat JARs don't include conflicting versions of Netty.
> It seems like this problem started when FLINK-6084 was implemented: transitive dependencies
of the flink-connector-cassandra were previously omitted, and now that they are included we
must make sure that they agree with the Flink distribution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message