flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG
Date Sun, 20 Aug 2017 15:12:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134468#comment-16134468
] 

ASF GitHub Bot commented on FLINK-7206:
---------------------------------------

Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4355#discussion_r134118240
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
    @@ -108,30 +112,38 @@ object AggregateUtil {
           outputArity,
           needRetract = false,
           needMerge = false,
    -      needReset = false
    +      needReset = false,
    +      accConfig = Some(DataViewConfig(accSpecs, isUseState))
         )
     
    +    val accConfig = accSpecs
    +      .flatMap(specs => specs.map(s => (s.id, s.toStateDescriptor)))
    +      .toMap[String, StateDescriptor[_, _]]
    +
         if (isRowTimeType) {
           if (isRowsClause) {
             // ROWS unbounded over process function
             new RowTimeUnboundedRowsOver(
               genFunction,
               aggregationStateType,
               CRowTypeInfo(inputTypeInfo),
    -          queryConfig)
    +          queryConfig,
    +          accConfig)
    --- End diff --
    
    +1 to do this. A great improvement! 


> Implementation of DataView to support state access for UDAGG
> ------------------------------------------------------------
>
>                 Key: FLINK-7206
>                 URL: https://issues.apache.org/jira/browse/FLINK-7206
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Kaibo Zhou
>            Assignee: Kaibo Zhou
>
> Implementation of MapView and ListView to support state access for UDAGG.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message