flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7269) Refactor passing of dynamic properties
Date Sun, 20 Aug 2017 20:06:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134553#comment-16134553
] 

ASF GitHub Bot commented on FLINK-7269:
---------------------------------------

Github user EronWright commented on the issue:

    https://github.com/apache/flink/pull/4415
  
    @tillrohrmann @zentol the whole reason for the static field is to allow the various sites
that call GlobalConfiguration.loadConfiguration to obtain the dynamic properties.    Any property
could be overridden.  Since there are many, many such sites, this patch causes a potential
regression.  
    
    Is there a driving rationale for this aside from a general dislike for statics?


> Refactor passing of dynamic properties
> --------------------------------------
>
>                 Key: FLINK-7269
>                 URL: https://issues.apache.org/jira/browse/FLINK-7269
>             Project: Flink
>          Issue Type: Improvement
>          Components: Configuration
>    Affects Versions: 1.3.1
>            Reporter: Till Rohrmann
>            Assignee: Fang Yong
>             Fix For: 1.4.0
>
>
> In order to set dynamic properties when loading the {{Configuration}} via {{GlobalConfiguration.loadConfiguration}},
we currently set a static field in {{GlobalConfiguration}} which is read whenever we load
the {{Configuration}}.
> I think this is not a good pattern I propose to remove this functionality. Instead we
should explicitly add the dynamic properties to the loaded {{Configuration}} at start of the
application.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message