flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7269) Refactor passing of dynamic properties
Date Sun, 20 Aug 2017 20:08:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134555#comment-16134555

ASF GitHub Bot commented on FLINK-7269:

Github user EronWright commented on the issue:

    There is only one true fix, that is to propagate the configuration instance everywhere
so that only the entrypoint calls loadConfiguration.

> Refactor passing of dynamic properties
> --------------------------------------
>                 Key: FLINK-7269
>                 URL: https://issues.apache.org/jira/browse/FLINK-7269
>             Project: Flink
>          Issue Type: Improvement
>          Components: Configuration
>    Affects Versions: 1.3.1
>            Reporter: Till Rohrmann
>            Assignee: Fang Yong
>             Fix For: 1.4.0
> In order to set dynamic properties when loading the {{Configuration}} via {{GlobalConfiguration.loadConfiguration}},
we currently set a static field in {{GlobalConfiguration}} which is read whenever we load
the {{Configuration}}.
> I think this is not a good pattern I propose to remove this functionality. Instead we
should explicitly add the dynamic properties to the loaded {{Configuration}} at start of the

This message was sent by Atlassian JIRA

View raw message