flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7312) activate checkstyle for flink/core/memory/*
Date Tue, 01 Aug 2017 16:30:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109222#comment-16109222

ASF GitHub Bot commented on FLINK-7312:

Github user StephanEwen commented on the issue:

    Final key-words on non-static methods should always be an exception, no matter whether
checkstyle marks them as a violation.
    Talking to @NicoK offline, he mentioned that there have been commits with such changes
merged. What do we do about these now? Are we sure we did not void a statement that the authors
put in place to the code to be future proof`?

> activate checkstyle for flink/core/memory/*
> -------------------------------------------
>                 Key: FLINK-7312
>                 URL: https://issues.apache.org/jira/browse/FLINK-7312
>             Project: Flink
>          Issue Type: Improvement
>          Components: Checkstyle, Core
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Minor

This message was sent by Atlassian JIRA

View raw message