flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7334) Replace Flink's futures by CompletableFuture in RpcGateway
Date Wed, 02 Aug 2017 16:45:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111256#comment-16111256
] 

ASF GitHub Bot commented on FLINK-7334:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4462#discussion_r130930816
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
---
    @@ -168,7 +165,7 @@ public void testHeartbeatTimeoutWithJobManager() throws Exception
{
     				eq(taskManagerLocation),
     				eq(jmLeaderId),
     				any(Time.class)
    -		)).thenReturn(FlinkCompletableFuture.<RegistrationResponse>completed(new JMTMRegistrationSuccess(jmResourceId,
blobPort)));
    +		)).thenReturn(java.util.concurrent.CompletableFuture.completedFuture(new JMTMRegistrationSuccess(jmResourceId,
blobPort)));
    --- End diff --
    
    True. Will change it.


> Replace Flink's futures by CompletableFuture in RpcGateway
> ----------------------------------------------------------
>
>                 Key: FLINK-7334
>                 URL: https://issues.apache.org/jira/browse/FLINK-7334
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message