flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7336) Remove Flink's futures from AkkaRpcActor
Date Tue, 01 Aug 2017 21:32:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109819#comment-16109819
] 

ASF GitHub Bot commented on FLINK-7336:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4450#discussion_r130734078
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcActor.java
---
    @@ -209,24 +207,20 @@ private void handleRpcInvocation(RpcInvocation rpcInvocation) {
     						return;
     					}
     
    -					if (result instanceof Future) {
    -						final Future<?> future = (Future<?>) result;
    -
    -						// pipe result to sender
    -						if (future instanceof FlinkFuture) {
    -							// FlinkFutures are currently backed by Scala's futures
    -							FlinkFuture<?> flinkFuture = (FlinkFuture<?>) future;
    -
    -							Patterns.pipe(flinkFuture.getScalaFuture(), getContext().dispatcher()).to(getSender());
    -						} else {
    -							// We have to unpack the Flink future and pack it into a Scala future
    -							Patterns.pipe(Futures.future(new Callable<Object>() {
    -								@Override
    -								public Object call() throws Exception {
    -									return future.get();
    +					if (result instanceof CompletableFuture) {
    --- End diff --
    
    I think you're right @zentol. These changes only make sense in combination with the changes
to the `RpcGateway` and `RpcEndpoint` I'm currently working on.


> Remove Flink's futures from AkkaRpcActor
> ----------------------------------------
>
>                 Key: FLINK-7336
>                 URL: https://issues.apache.org/jira/browse/FLINK-7336
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message