flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7442) Add option for using a child-first classloader for loading user code
Date Fri, 18 Aug 2017 13:18:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132168#comment-16132168
] 

ASF GitHub Bot commented on FLINK-7442:
---------------------------------------

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/4564

    [FLINK-7442] Add option for using child-first classloader for loading user code

    This is an alternative to #4554 that does not make the client class loader configurable.
    
    ## What is the purpose of the change
    
    This PR introduces a new core option (`classloader.resolve-order: child-first`) that allows
using a child-first class loader for user code. The default is still to use a parent-first
class loader.
    
    This also does a minor refactoring in the way the blob manager retrieves the cleanup interval.
It's now also read from the `Configuration`, since we already have the `Configuration` for
the class loader settings.
    
    ## Brief change log
    
     - Introduce new option
     - Pass `Configuration` thought to all places where we previously created a user class
loader
     - Instantiate correct class loader based on config
    
    ## Verifying this change
    
    This PR introduces new end-to-end tests that verify the new feature in a complete Flink
workflow, including starting the program using `bin/flink run`.
    
    ## Does this pull request potentially affect one of the following parts:
    
    
    This affects class loader, which is quite important to get right.
    
    ## Documentation
    
     - the new flag is documented in the config documentation


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink jira-7441-child-first-classloader-alternative

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4564.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4564
    
----
commit 33bd4cf5160ec64cbaace876b305922b804cc3a1
Author: Aljoscha Krettek <aljoscha.krettek@gmail.com>
Date:   2017-08-14T12:53:14Z

    [FLINK-7442] Add option for using a child-first classloader for loading user code

----


> Add option for using a child-first classloader for loading user code
> --------------------------------------------------------------------
>
>                 Key: FLINK-7442
>                 URL: https://issues.apache.org/jira/browse/FLINK-7442
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message