flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7443) Store and deserializer fields in MetricFetcher should be final
Date Mon, 14 Aug 2017 22:14:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126495#comment-16126495
] 

ASF GitHub Bot commented on FLINK-7443:
---------------------------------------

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4539
  
    +1 but I'm only seeing an improvement and not a bug


> Store and deserializer fields in MetricFetcher should be final
> --------------------------------------------------------------
>
>                 Key: FLINK-7443
>                 URL: https://issues.apache.org/jira/browse/FLINK-7443
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>
> The {{MetricStore}} and {{MetricDumpDeserializer}} fields in the {{MetricFetcher}} should
be final, as they are not meant to be overwritten and are even used for synchronization.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message