flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7451) Query fails when non-ascii characters are used in string literals
Date Tue, 15 Aug 2017 11:33:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127100#comment-16127100
] 

ASF GitHub Bot commented on FLINK-7451:
---------------------------------------

GitHub user wuchong opened a pull request:

    https://github.com/apache/flink/pull/4544

    [FLINK-7451] [table] Support non-ascii character literals in Table API and SQL

    ## What is the purpose of the change
    
    The non-ascii characters in string literals causes calcite planner to throw the following
exception:
    
     ```
    Failed to encode '%测试%' in character set 'ISO-8859-1'
    ```
    
    ## Brief change log
    
    - add default charset for FlinkTypeFactory
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
    - Added expression test for non-ascii literals
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? na
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wuchong/flink non-ascii

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4544.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4544
    
----
commit 6013d2693a4eb3622dc1cbb7d27829ee5b566713
Author: Jark Wu <jark@apache.org>
Date:   2017-08-15T11:24:57Z

    [FLINK-7451] [table] Support non-ascii character literals in Table API and SQL

----


> Query fails when non-ascii characters are used in string literals
> -----------------------------------------------------------------
>
>                 Key: FLINK-7451
>                 URL: https://issues.apache.org/jira/browse/FLINK-7451
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>
> I found that using non-ascii characters in string literals causes calcite planner to
throw the following exception:
> {code}
> org.apache.calcite.runtime.CalciteException: Failed to encode '%测试%' in character
set 'ISO-8859-1'
> {code}
> The query is 
> {code}
> SELECT * FROM T WHERE f0 LIKE '%测试%'
> {code}
> The reason for the issue is that calcite uses latin encoding ('ISO-8859-1') by default.
In order to pass non-latin characters we should use unicode encoding as default.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message