From issues-return-127627-apmail-flink-issues-archive=flink.apache.org@flink.apache.org Tue Aug 15 16:10:23 2017 Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9E8041AB8B for ; Tue, 15 Aug 2017 16:10:23 +0000 (UTC) Received: (qmail 30855 invoked by uid 500); 15 Aug 2017 16:10:23 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 30813 invoked by uid 500); 15 Aug 2017 16:10:23 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 30804 invoked by uid 99); 15 Aug 2017 16:10:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Aug 2017 16:10:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B4FE718077D for ; Tue, 15 Aug 2017 16:10:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id N3-ovyREhgcW for ; Tue, 15 Aug 2017 16:10:22 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 16A265F5B6 for ; Tue, 15 Aug 2017 16:10:20 +0000 (UTC) Received: (qmail 30785 invoked by uid 99); 15 Aug 2017 16:10:20 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Aug 2017 16:10:20 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 26918E009E; Tue, 15 Aug 2017 16:10:20 +0000 (UTC) From: pnowojski To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #4515: Logging improvements in NetworkFailuresProxy Content-Type: text/plain Message-Id: <20170815161020.26918E009E@git1-us-west.apache.org> Date: Tue, 15 Aug 2017 16:10:20 +0000 (UTC) Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4515#discussion_r133231386 --- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/networking/NetworkFailureHandler.java --- @@ -92,7 +92,14 @@ public void channelOpen(ChannelHandlerContext context, ChannelStateEvent event) final Channel sourceChannel = event.getChannel(); sourceChannel.setReadable(false); - if (blocked.get()) { + boolean isBlocked = blocked.get(); + LOG.debug("Attempt to open proxy channel from [%s] to [%s:%s] in state [blocked = %s]", --- End diff -- Sorry I didn't fix this nit, I was OoO :( thanks for merging! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---