flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...
Date Tue, 05 Sep 2017 21:50:13 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4625#discussion_r137032484
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/WindowJoinUtil.scala
---
    @@ -225,7 +233,7 @@ object WindowJoinUtil {
               case t: TimeIndicatorRelDataType =>
                 // time attribute access. Remember time type and side of input
                 val isLeftInput = idx < leftFieldCount
    -            Seq(TimeAttributeAccess(t.isEventTime, isLeftInput))
    +            Seq(TimeAttributeAccess(t.isEventTime, isLeftInput, idx))
    --- End diff --
    
    I would do the subtraction here:
    
    ```
    if (idx < leftFieldCount) {
      Seq(TimeAttributeAccess(t.isEventTime, true, idx))
    } else {
      Seq(TimeAttributeAccess(t.isEventTime, false, idx - leftFieldCount))
    }
    ```



---

Mime
View raw message