flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...
Date Tue, 05 Sep 2017 21:50:13 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4625#discussion_r137020297
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/WindowJoinUtil.scala
---
    @@ -39,14 +39,17 @@ import scala.collection.JavaConverters._
       */
     object WindowJoinUtil {
     
    -  case class WindowBounds(isEventTime: Boolean, leftLowerBound: Long, leftUpperBound:
Long)
    +  case class WindowBounds(isEventTime: Boolean, leftLowerBound: Long, leftUpperBound:
Long,
    --- End diff --
    
    change formatting to
    ```
    case class WindowBounds(
      isEventTime: Boolean,
      leftLowerBound: Long,
      ...,
      rightTimeIdx: Int)
    ```
    similar to `TimePredicate`


---

Mime
View raw message