flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...
Date Tue, 05 Sep 2017 21:50:17 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4625#discussion_r137123724
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/JoinHarnessTest.scala
---
    @@ -232,4 +232,164 @@ class JoinHarnessTest extends HarnessTestBase{
         testHarness.close()
       }
     
    +  /** a.proctime >= b.proctime - 10 and a.proctime <= b.proctime + 20 **/
    +  @Test
    +  def testNewNormalProcTimeJoin() {
    --- End diff --
    
    We would also need harness tests for the event-time join.
    In addition we need:
    - plan translation tests (see `org.apache.flink.table.api.stream.sql.JoinTest`)
    - some end-to-end ITCases (see `org.apache.flink.table.runtime.stream.sql.JoinITCase`
but with result validation)
    
    Moreover, the processing time restriction for windowed joins should be removed from the
documentation.


---

Mime
View raw message