flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xccui <...@git.apache.org>
Subject [GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...
Date Tue, 05 Sep 2017 23:13:42 GMT
Github user xccui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4625#discussion_r137137915
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamWindowJoinRule.scala
---
    @@ -55,8 +55,10 @@ class DataStreamWindowJoinRule
     
         if (windowBounds.isDefined) {
           if (windowBounds.get.isEventTime) {
    -        // we cannot handle event-time window joins yet
    -        false
    +        val procTimeAttrInOutput = join.getRowType.getFieldList.asScala
    +          .exists(f => FlinkTypeFactory.isProctimeIndicatorType(f.getType))
    +
    +        !remainingPredsAccessTime && !procTimeAttrInOutput
    --- End diff --
    
    Shall we also keep the rowtime attributes in the outputs of proctime join?


---

Mime
View raw message