flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink issue #4647: [FLINK-7575] [WEB-DASHBOARD] Display "Fetching..." instea...
Date Wed, 06 Sep 2017 07:59:48 GMT
Github user uce commented on the issue:

    https://github.com/apache/flink/pull/4647
  
    Thanks @zentol for the review.
    
    @jameslafa 
    - Regarding the first point with checkstyle: It's confusing that our checkstyle settings
don't catch this, but Chesnay is right here. Seems nitpicky but we try to avoid unnecessary
formatting changes.
    - Regarding the changes to the *.js files: Since you didn't change any of the coffee scripts,
there should be no need to commit those files and I would also suggest to remove those changes.
The changes are probably due to different versions on your machine and the previous contributor
who changed the files. I think this only reinforces the argument we had about committing the
*.lock file too. Could you create a new JIRA for this?
    
    @zentol 
    - I didn't understand your follow up comments regarding the `metricsFetched` flag. Could
you please elaborate on what you mean? Is the flag ok to keep after #4472 is merged?
    



---

Mime
View raw message