flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl0u <...@git.apache.org>
Subject [GitHub] flink pull request #4644: [FLINK-7581] [REST] Name netty threads
Date Wed, 06 Sep 2017 08:11:13 GMT
Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4644#discussion_r137198747
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestServerEndpoint.java
---
    @@ -104,8 +105,8 @@ protected void initChannel(SocketChannel ch) {
     			}
     		};
     
    -		NioEventLoopGroup bossGroup = new NioEventLoopGroup(1);
    -		NioEventLoopGroup workerGroup = new NioEventLoopGroup();
    +		NioEventLoopGroup bossGroup = new NioEventLoopGroup(1, new DefaultThreadFactory("flink-rest-server-netty-boss"));
    +		NioEventLoopGroup workerGroup = new NioEventLoopGroup(1, new DefaultThreadFactory("flink-rest-server-netty-worker"));
     
    --- End diff --
    
    Why setting the worker group thread pool size to 1? Leaving it to 0 will give you `Runtime.getRuntime().availableProcessors()
* 2`.


---

Mime
View raw message