flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4485: [FLINK-7378][core]Create a fix size (non rebalanci...
Date Thu, 14 Sep 2017 13:47:40 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4485#discussion_r138897087
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
---
    @@ -333,7 +333,7 @@ public void updateInputChannel(InputChannelDeploymentDescriptor icdd)
throws IOE
     
     			InputChannel current = inputChannels.get(partitionId);
     
    -			if (current.getClass() == UnknownInputChannel.class) {
    +			if (current instanceof UnknownInputChannel) {
    --- End diff --
    
    Just to be on the safe side, you should also change this check in `#setInputChannel()`
above. This way, we handle all sub-classes of `UnknownInputChannel` the same way as `UnknownInputChannel`
itself


---

Mime
View raw message