flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...
Date Mon, 18 Sep 2017 15:51:49 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4625#discussion_r139402125
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/JoinHarnessTest.scala
---
    @@ -383,13 +384,158 @@ class JoinHarnessTest extends HarnessTestBase{
         val expectedOutput = new ConcurrentLinkedQueue[Object]()
     
         expectedOutput.add(new StreamRecord(
    -      CRow(Row.of(2: JInt, "aaa2", 2: JInt, "bbb7"), true), 7))
    +      CRow(Row.of(2L: JLong, "aaa2", 2L: JLong, "bbb7"), true), 7))
         expectedOutput.add(new StreamRecord(
    -      CRow(Row.of(1: JInt, "aaa3", 1: JInt, "bbb12"), true), 12))
    +      CRow(Row.of(1L: JLong, "aaa3", 1L: JLong, "bbb12"), true), 12))
     
         verify(expectedOutput, result, new RowResultSortComparator())
     
         testHarness.close()
       }
     
    +  /** a.c1 >= b.rowtime - 10 and a.rowtime <= b.rowtime + 20 **/
    +  @Test
    +  def testCommonRowTimeJoin() {
    --- End diff --
    
    These tests are a good start. 
    We also need a few (2 +/- 1) end-to-end tests (see `org.apache.flink.table.runtime.stream.sql.JoinITCase`)
that check the correct translation and execution (incl. result validation).


---

Mime
View raw message