flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...
Date Mon, 18 Sep 2017 15:51:49 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4625#discussion_r139385852
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala
---
    @@ -57,6 +61,8 @@ class DataStreamWindowJoin(
         with CommonJoin
         with DataStreamRel {
     
    +  lazy val LOG: Logger = LoggerFactory.getLogger(getClass)
    --- End diff --
    
    use `Logging` trait instead of creating logger yourself.


---

Mime
View raw message