flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...
Date Mon, 18 Sep 2017 20:52:10 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3829#discussion_r139529093
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
    @@ -554,10 +680,14 @@ abstract class TableEnvironment(val config: TableConfig) {
         * @param name The table name to check.
         * @return true, if a table is registered under the name, false otherwise.
         */
    -  protected def isRegistered(name: String): Boolean = {
    +  protected[flink] def isRegistered(name: String): Boolean = {
         rootSchema.getTableNames.contains(name)
       }
     
    +  protected[flink] def getTable(name: String): org.apache.calcite.schema.Table = {
    --- End diff --
    
    can we make this a `private` method? Otherwise it will be visible from Java and confuse
users (the returned Table is not a Table API Table but a Calcite Table).


---

Mime
View raw message