flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink issue #4625: [FLINK-6233] [table] Support time-bounded stream inner jo...
Date Tue, 19 Sep 2017 15:33:16 GMT
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/4625
  
    Btw, I noticed I did not reply to your comments. 
    
    I think it would be good to have the eager state cleaning in the initial version. Shouldn't
be too much effort. Basically, getting the condition right and calling `remove()` on the `Map.Entry`.
    
    What do you mean by "distinguish the < and <=signs"? If there is an off-by-one issue
in the computation of the window boundaries, it needs to be fixed with this PR. We shouldn't
merge a semantically incorrect operator (of course there might be bugs...). Performance issues
are OK but the semantics must be correct.
    
    Regarding the `"misc"` test failures, yes that can happen. No need to worry about that
as long as the `""` libraries build passes. I'll run the tests anyway again before merging
;-)


---

Mime
View raw message