flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #4616: [FLINK-7552] [FLINK-7553] Enhance SinkInterface / Use in ...
Date Wed, 20 Sep 2017 13:14:02 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4616
  
    +1 from my side to merge it like this (using boxed long, dropping the `hasTimestamp()`
method.
    
    My reasoning is that this is consistent with `ProcessFunction` (like @EronWright said),
it is also not in a hot loop and lazily created, so I do not expect a big performance hit.
    
    @aljoscha and me talked a lot about the whole design of when records have timestamps and
whether in the future we should just assume that records always have timestamps. That biased
my towards dropping the `hasTimestamp()` method.


---

Mime
View raw message