flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4485: [FLINK-7378][core]Create a fix size (non rebalanci...
Date Thu, 21 Sep 2017 09:23:45 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4485#discussion_r140190096
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPoolTest.java
---
    @@ -264,11 +271,13 @@ public void testRequestMemorySegmentsWithBuffersTaken() throws IOException,
Inte
     				assertNotNull(buffer);
     			}
     
    -			// if requestMemorySegments() blocks, this will make sure that enough buffers are
freed
    -			// eventually for it to continue
    +			// requestMemorySegments() below will and wait for buffers
    --- End diff --
    
    typo from my code example: should be "below will wait for buffers"


---

Mime
View raw message