flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haohui <...@git.apache.org>
Subject [GitHub] flink pull request #4544: [FLINK-7451] [table] Support non-ascii character l...
Date Mon, 25 Sep 2017 07:21:24 GMT
Github user haohui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4544#discussion_r140703450
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkTypeFactory.scala
---
    @@ -269,6 +272,10 @@ class FlinkTypeFactory(typeSystem: RelDataTypeSystem) extends JavaTypeFactoryImp
     
         canonize(newType)
       }
    +
    +  override def getDefaultCharset: Charset = {
    +    Charset.forName(ConversionUtil.NATIVE_UTF16_CHARSET_NAME)
    --- End diff --
    
    Should we do UTF-8 by default?
    
    You can just use `java.nio.charset.StandardCharsets.UTF_8` to avoid introducing additional
dependency.


---

Mime
View raw message