flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4699: [FLINK-7663] [flip6] Return BAD_REQUEST if Handler...
Date Tue, 26 Sep 2017 17:04:29 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4699#discussion_r141119740
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/RestEndpointITCase.java
---
    @@ -162,8 +225,8 @@ public void testEndpoints() throws Exception {
     
     		@Override
     		protected CompletableFuture<TestResponse> handleRequest(@Nonnull HandlerRequest<TestRequest,
TestParameters> request, RestfulGateway gateway) throws RestHandlerException {
    -			Assert.assertEquals(request.getPathParameter(JobIDPathParameter.class), PATH_JOB_ID);
    -			Assert.assertEquals(request.getQueryParameter(JobIDQueryParameter.class).get(0), QUERY_JOB_ID);
    +			assertEquals(request.getPathParameter(JobIDPathParameter.class), PATH_JOB_ID);
    --- End diff --
    
    How about we stick to the import pattern that already exists in a given file instead of
switching back and forth?


---

Mime
View raw message