flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4728: [FLINK-7668] Add ExecutionGraphCache for Execution...
Date Tue, 26 Sep 2017 17:24:37 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4728#discussion_r141125073
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/RestfulGateway.java
---
    @@ -38,5 +44,36 @@
     	 * @param timeout for this operation
     	 * @return Future REST endpoint address
     	 */
    -	CompletableFuture<String> requestRestAddress(Time timeout);
    +	CompletableFuture<String> requestRestAddress(@RpcTimeout  Time timeout);
    +
    +	/**
    +	 * Requests the AccessExecutionGraph for the given jobId. If there is no such graph,
then
    +	 * the future is completed with a {@link JobNotFoundException}.
    +	 *
    +	 * @param jobId identifying the job whose AccessExecutionGraph is requested
    +	 * @param timeout for the asynchronous operation
    +	 * @return Future containing the AccessExecutionGraph for the given jobId, otherwise
{@link JobNotFoundException}
    +	 */
    +	CompletableFuture<AccessExecutionGraph> requestJob(JobID jobId, @RpcTimeout Time
timeout);
    --- End diff --
    
    Well this seems questionable. These methods technically aren't related to being a restful
gateway,
    
    This seems like an odd attempt to reduce code duplication by just moving the code one
layer up without other considerations.


---

Mime
View raw message