flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request #4722: [FLINK-7683] Iterate over keys in KeyedStateBacken...
Date Wed, 27 Sep 2017 08:20:25 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4722#discussion_r141272559
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackend.java
---
    @@ -37,6 +39,12 @@
     	void setCurrentKey(K newKey);
     
     	/**
    +	 * @return Stream of existing keys in the namespace.
    --- End diff --
    
    Nit: This could be changed to "Returns a stream of all keys for the given state and namespace.".
The first parameter should be renamed to `state` or something like it because `field` is not
used anywhere else, I think.


---

Mime
View raw message